webkit_rendering: disable dmabuf renderer for AMD GPUs - #3695
Open
Christian-Sidak wants to merge 1 commit into
Open
webkit_rendering: disable dmabuf renderer for AMD GPUs#3695Christian-Sidak wants to merge 1 commit into
Christian-Sidak wants to merge 1 commit into
Conversation
AMD Radeon devices (PCI vendor 0x1002) trigger the same WebKitGTK dmabuf blank-screen as NVIDIA on some compositor/kernel combinations. Widen the heuristic to cover AMD GPUs by generalising nvidia_gpu() into gpu_vendor(drm_root, vendor_id) and adding AMD_PCI_VENDOR to the signals array. Fixes block#3656 Signed-off-by: Christian-Sidak <61099993+Christian-Sidak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AMD Radeon devices (PCI vendor
0x1002) trigger the same WebKitGTK dmabuf blank-screen crash as NVIDIA on some compositor/kernel combinations. This was reported in #3656 by a user on CachyOS + Hyprland with a Radeon Vega Mobile GPU.nvidia_gpu(drm_root)helper intogpu_vendor(drm_root, vendor_id)so vendor detection is reusable without duplicationAMD_PCI_VENDOR = "0x1002"constantThe
--safe-renderingescape hatch and all user-environment-override logic are unchanged.Test plan
cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --checkpassescargo clippy --manifest-path desktop/src-tauri/Cargo.toml --libpasses with no warningscargo check --manifest-path desktop/src-tauri/Cargo.toml --libcompiles cleanlyjust desktop-tauri-testpasses (requires Linux build environment with opus; macOS CI will cover this)Fixes #3656